my bike is not charging so I have changed regulator on it but what else could be the problem ?

Edited May 22, 20195 yr by tauber71

Have you checked that the battery is accepting a charge? Make sure it's actually not putting out voltage. It could also be that the stator has given out, also check for bad grounds, lose wires, all the usual stuff